Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): run tasks with no dependencies in topological order #13294

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Tasks are run according to which has the most task dependencies. But this makes no difference for tasks with no dependencies such as test and lint targets.

However, it is most important to run the tests from projects that are depended upon the most.

Expected Behavior

When running tests or lint or other flat task graphs, tasks will be ordered according to topological order. This will feedback for failing tests in the projects that are depended upon the most before projects that are depended upon the least.

Related Issue(s)

Fixes #13258

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 4:27PM (UTC)

@FrozenPandaz FrozenPandaz requested a review from vsavkin November 21, 2022 22:02
@FrozenPandaz FrozenPandaz self-assigned this Nov 21, 2022
@FrozenPandaz FrozenPandaz merged commit 1842d19 into nrwl:master Nov 21, 2022
@FrozenPandaz FrozenPandaz deleted the topological-tasks branch November 21, 2022 22:08
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the order of tasks to run
1 participant