Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize project graph file mapping #13249

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Nov 18, 2022

Current Behavior

The mapProjectGraphFiles creates an extended ProjectGraph structure that includes the allFiles lookup map.

Expected Behavior

  • Rename mapProjectGraphFiles to createProjectFileMappings to match existing logic in TargetProjectLocator
  • Extract the file lookup map to keep it separate from the project graph.

Related Issue(s)

Followup to #13222

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 18, 2022 at 1:08PM (UTC)

@meeroslav meeroslav self-assigned this Nov 18, 2022
@meeroslav meeroslav changed the title feat(core): simplify project graph file mapping for linter rule feat(core): optimize project graph file mapping Nov 18, 2022
@meeroslav meeroslav added the scope: core core nx functionality label Nov 18, 2022
@meeroslav meeroslav merged commit de44bf8 into nrwl:master Nov 18, 2022
@meeroslav meeroslav deleted the cleanup-map-project-graph branch November 21, 2022 13:59
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Nov 23, 2022
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Nov 23, 2022
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Nov 24, 2022
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Nov 24, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant