-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): use provideRouter for standalone apps #12012
Merged
Coly010
merged 1 commit into
nrwl:master
from
Coly010:angular/use-provide-router-for-standalone
Sep 29, 2022
Merged
feat(angular): use provideRouter for standalone apps #12012
Coly010
merged 1 commit into
nrwl:master
from
Coly010:angular/use-provide-router-for-standalone
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
force-pushed
the
angular/use-provide-router-for-standalone
branch
2 times, most recently
from
September 14, 2022 16:05
a344427
to
e12fcbe
Compare
Coly010
added
the
target: next major version
To be merged for the next major version release
label
Sep 22, 2022
Coly010
force-pushed
the
angular/use-provide-router-for-standalone
branch
from
September 28, 2022 15:06
e12fcbe
to
aa9be9f
Compare
leosvelperez
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
packages/angular/src/generators/application/lib/convert-to-standalone-app.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
angular/use-provide-router-for-standalone
branch
from
September 29, 2022 08:54
aa9be9f
to
aa466c9
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
importProvidersFrom
toprovideRouter
for standalone apps