Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): use provideRouter for standalone apps #12012

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 14, 2022

Switch from importProvidersFrom to provideRouter for standalone apps

@Coly010 Coly010 self-assigned this Sep 14, 2022
@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 29, 2022 at 8:54AM (UTC)

@Coly010 Coly010 marked this pull request as draft September 14, 2022 09:24
@Coly010 Coly010 force-pushed the angular/use-provide-router-for-standalone branch 2 times, most recently from a344427 to e12fcbe Compare September 14, 2022 16:05
@Coly010 Coly010 marked this pull request as ready for review September 20, 2022 14:23
@Coly010 Coly010 added the target: next major version To be merged for the next major version release label Sep 22, 2022
@Coly010 Coly010 force-pushed the angular/use-provide-router-for-standalone branch from e12fcbe to aa9be9f Compare September 28, 2022 15:06
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 force-pushed the angular/use-provide-router-for-standalone branch from aa9be9f to aa466c9 Compare September 29, 2022 08:54
@Coly010 Coly010 merged commit 0858bcf into nrwl:master Sep 29, 2022
@Coly010 Coly010 deleted the angular/use-provide-router-for-standalone branch September 29, 2022 09:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: next major version To be merged for the next major version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants