Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack): add webpack plugin #11966

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 10, 2022

This PR moves webpack-specific generators and executors to the new @nrwl/webpack plugin. This change is the first step to enabling more bundlers like esbuild, vite, etc.

Changes

  • Consolidate webpack executor from web and node into @nrwl/webpack:webpack with support for babel, swc, and tsc
  • Move @nrwl/web:dev-server executor to @nrwl/webpack:dev-server
  • Add backwards-compat API for previous executors (in case anyone is using them in custom executors)
    • @nrwl/web:webpack re-exports @nrwl/webpack:webpack
    • @nrwl/webpack:dev-server re-exports @nrwl/webpack:dev-server
    • @nrwl/node:webpack invokes @nrwl/webpack:webpack with target: 'node'
  • Common webpack utilities in @nrwl/web are re-exported from @nrwl/webpack for backwards compatibility
  • Migrate existing usages of webpack executors to @nrwl/webpack
    • @nrwl/web:webpack replaced by @nrwl/webpack:webpack
    • @nrwl/web:dev-server replaced by @nrwl/webpack:dev-server
    • @nrwl/node:webpack replaced by @nrwl/webpack:webpack (with options { compiler: 'tsc', target: 'node' })

@vercel
Copy link

vercel bot commented Sep 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 7:59PM (UTC)

@jaysoo jaysoo marked this pull request as ready for review September 11, 2022 01:37
@jaysoo jaysoo force-pushed the feat/move-webpack branch 3 times, most recently from 1e84564 to b54c195 Compare September 12, 2022 17:39
@jaysoo jaysoo force-pushed the feat/move-webpack branch 2 times, most recently from 8e273ad to 3f19415 Compare September 12, 2022 18:10
@jaysoo jaysoo enabled auto-merge (squash) September 12, 2022 19:00
isScriptOptimizeOn,
emitDecoratorMetadata,
configuration: overrides?.configuration ?? context.configurationName,
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the skipTypeCheck property is missing. How to override it from executor config?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants