Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Nx > 11.0.0 should update ngrx to 11.1.0 #5261

Closed
santoshyadavdev opened this issue Apr 7, 2021 · 4 comments · Fixed by #5321
Closed

Migration to Nx > 11.0.0 should update ngrx to 11.1.0 #5261

santoshyadavdev opened this issue Apr 7, 2021 · 4 comments · Fixed by #5321
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@santoshyadavdev
Copy link
Contributor

There is an issue with NgRx 11 ngrx/platform#2919 which is fixed in 11.0.1 as per the comments.

If you can help me where to make changes , I will be more than happy to raise a PR.

Current Behavior

Migration to Nx does not update ngrx

Expected Behavior

It should update ngrx version as well.

Steps to Reproduce

Failure Logs

Environment

@FrozenPandaz FrozenPandaz added the scope: angular Issues related to Angular support in Nx label Apr 9, 2021
@brandonroberts
Copy link
Contributor

Thanks @santoshyadavdev! There are a few files you have to update for this:

That should be what you need for a PR.

@santoshyadavdev
Copy link
Contributor Author

Thanks @brandonroberts , PR coming soon 😀

@saleemmalikraja
Copy link

Thanks @santoshyadavdev . Faced the same issue and ended up finding this post to fix it :)

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants