-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests failing for fresh generated plugin #3933
Labels
Comments
Opening PR with this fix |
sebastiandg7
changed the title
e2e tests failing for fresh generated plugin
E2E tests failing for fresh generated plugin
Oct 17, 2020
vsavkin
pushed a commit
that referenced
this issue
Oct 29, 2020
replace the property name version with the plain version of the plugin name in the plugins e2e tests in order to coincide with the generated schematic name ISSUES CLOSED: #3933
Doginal
pushed a commit
to Doginal/nx
that referenced
this issue
Nov 25, 2020
replace the property name version with the plain version of the plugin name in the plugins e2e tests in order to coincide with the generated schematic name ISSUES CLOSED: nrwl#3933
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
When a nx-plugin containing a dash in its name, 'my-plugin' as an example, is generated, the default e2e tests fail because the generated schematic follows the same name as the plugin ('my-plugin') but the e2e tests try to execute the schematic using the property name version of the plugin.
Expected Behavior
e2e test for generated plugins should succeed if no changes has been made after the plugin generation.
Steps to Reproduce
$ npx create-nx-plugin my-org --pluginName my-plugin $ cd my-org $ yarn e2e my-plugin-e2e
Failure Logs
Expand to see logs
Environment
`nx report` output
The text was updated successfully, but these errors were encountered: