Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom webpack config does not work with async functions anymore #28200

Closed
1 of 4 tasks
woppa684 opened this issue Sep 30, 2024 · 1 comment · Fixed by #28213
Closed
1 of 4 tasks

Custom webpack config does not work with async functions anymore #28200

woppa684 opened this issue Sep 30, 2024 · 1 comment · Fixed by #28213
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@woppa684
Copy link

woppa684 commented Sep 30, 2024

Current Behavior

Having a custom webpack config as an async function does not work anymore

Expected Behavior

A custom webpack config can be an async function

GitHub Repo

No response

Steps to Reproduce

This functional was broken in 7b3f45b
where the merge function changed from returning the result of the async function directly, to wanting to do something with the output. The comment above the function even states that the function can be async. In that case it must be awaited. See

// The extra Webpack configuration file can export a synchronous or asynchronous function,

Nx Report

Node           : 20.15.0
OS             : win32-x64
Native Target  : x86_64-windows
pnpm           : 9.7.0

nx                 : 19.8.2
@nx/js             : 19.8.2
@nx/jest           : 19.8.2
@nx/linter         : 19.8.2
@nx/eslint         : 19.8.2
@nx/workspace      : 19.8.2
@nx/angular        : 19.8.2
@nx/devkit         : 19.8.2
@nx/eslint-plugin  : 19.8.2
@nx/plugin         : 19.8.2
@nrwl/tao          : 19.8.2
@nx/web            : 19.8.2
@nx/webpack        : 19.8.2
typescript         : 5.5.4
---------------------------------------
Community plugins:
@ngrx/store       : 18.0.2
---------------------------------------
Local workspace plugins:
         tools

Failure Logs

C:\Repo\node_modules\.pnpm\r[email protected]\node_modules\rxjs\dist\cjs\internal\util\reportUnhandledError.js:13
            throw err;
            ^
TypeError: Cannot read properties of undefined (reading 'find')
    at mergeCustomWebpackConfig (C:\Repo\node_modules\.pnpm\@[email protected]_6a73c5d7a5ewxppdi4fq6xr76m\node_modules\@nx\angular\src\builders\utilities\webpack.js:32:45)
    at initialize (C:\Repo\node_modules\.pnpm\@[email protected]_@[email protected]_@[email protected]_@a_i326fgdiiy6b3oafnjsagxikom\node_modules\@angular-devkit\build-angular\src\builders\browser\index.js:71:29)
    at C:\Repo\node_modules\.pnpm\@[email protected]_@[email protected]_@[email protected]_@a_i326fgdiiy6b3oafnjsagxikom\node_modules\@angular-devkit\build-angular\src\builders\browser\index.js:95:32

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

woppa684 referenced this issue Sep 30, 2024
…#27989 (#27994)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
The `license-webpack-plugin` is trying to scan the root package.json on
windows, resulting in an error.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Patch the `license-webpack-plugin` to prevent it from scanning the root
package.json. A similar fix was needed for rspack.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27989
@Coly010 Coly010 self-assigned this Oct 1, 2024
@Coly010 Coly010 added the scope: angular Issues related to Angular support in Nx label Oct 1, 2024
@Coly010 Coly010 closed this as completed in 54936f9 Oct 1, 2024
FrozenPandaz pushed a commit that referenced this issue Oct 1, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Custom webpack functions may return a promise that needs to be awaited
before we attempt to do any additional work on it


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure custom webpack functions are awaited. they will no-op for
synchronous functions

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28200
Copy link

github-actions bot commented Nov 1, 2024

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants