-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom webpack config does not work with async functions anymore #28200
Labels
Comments
woppa684
referenced
this issue
Sep 30, 2024
…#27989 (#27994) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The `license-webpack-plugin` is trying to scan the root package.json on windows, resulting in an error. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Patch the `license-webpack-plugin` to prevent it from scanning the root package.json. A similar fix was needed for rspack. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27989
Coly010
added a commit
that referenced
this issue
Oct 1, 2024
Coly010
added a commit
that referenced
this issue
Oct 1, 2024
FrozenPandaz
pushed a commit
that referenced
this issue
Oct 1, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Custom webpack functions may return a promise that needs to be awaited before we attempt to do any additional work on it ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Ensure custom webpack functions are awaited. they will no-op for synchronous functions ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28200
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
Having a custom webpack config as an async function does not work anymore
Expected Behavior
A custom webpack config can be an async function
GitHub Repo
No response
Steps to Reproduce
This functional was broken in 7b3f45b
where the merge function changed from returning the result of the async function directly, to wanting to do something with the output. The comment above the function even states that the function can be async. In that case it must be awaited. See
nx/packages/angular/src/builders/utilities/webpack.ts
Line 24 in 2a70629
Nx Report
Failure Logs
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: