Sharing sub packages when collecting shared packages for the Module Federation setup. #28137
Closed
1 of 4 tasks
Comments
Coly010
added a commit
that referenced
this issue
Oct 1, 2024
…en applying to support transitive deps #28137
FrozenPandaz
pushed a commit
that referenced
this issue
Oct 1, 2024
…en applying to support transitive deps #28137 (#28216) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Transitive deps may not exist on the project graph or be installed in the root package.json file. They could require the singleton pattern and should use the `additionalShared` functionality. However, the additionalShared will check project graph and root package.json, erroring if the package cannot be found. The last resort should be to use `require.resolve` to check the node_modules folder to find the package.json of the package and select a version from it. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28137
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
We are currently attempting to share a sub-package from one of our npm packages using NX module federation. However, we are receiving warnings that the package cannot be found within our package.json and therefore won't be shared. This makes sense since it's a sub-package. Is there any way we can share this package without declaring it within the package.json?
In our package.json, we installed the package as @my-package/angular
The npm package is set up like this:
@My-package
|-- @my-package/angular
|-- @my-package/icons
|-- @my-package/elements <---- this is what we are trying to share within the module federation config
Expected Behavior
Sub packages to be shared within the module federation config
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: