@nx/vite:build doesn't set NODE_ENV properly

[CreativeTechGuy]

Current Behavior

NX loads my vite config, then loads vite, then passes my resolved vite config object to the vite build command. The vite build command will first set NODE_ENV to the appropriate value if it's not already set. But since my vite config reads that to determine parts of the config itself, it'll read NODE_ENV before vite has a chance to set it.

Expected Behavior

Without using NX, this exact same thing works fine since vite CLI would run, which would then pass the string path of my config to the build command which then sets the environment and then loads my config. I'd expect that NX would work the same way.

There may be other differences, but I'm specifically asking if NODE_ENV can be set in the NX executor to the appropriate value (eg: "production" in the case of the production build) before evaluating my config file.

GitHub Repo

No response

Steps to Reproduce

1. Make a vite config which console.log(process.env.NODE_ENV)
2. Run the vite build command with vanilla vite and observe the output ("production")
3. Run the vite build command with NX vite executor and observe the output (undefined)

Nx Report

Node           : 20.14.0
OS             : win32-x64
Native Target  : x86_64-windows
npm            : 10.7.0
 
nx                 : 19.6.1
@nx/js             : 19.6.1
@nx/linter         : 19.6.1
@nx/eslint         : 19.6.1
@nx/workspace      : 19.6.1
@nx/devkit         : 19.6.1
@nx/esbuild        : 19.6.1
@nx/eslint-plugin  : 19.6.1
@nrwl/tao          : 19.6.1
@nx/vite           : 19.6.1
typescript         : 5.5.4

Failure Logs

No response

Package Manager Version

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.