Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx 19.2.3 Angular 17.3.8 SSR with provideClientHydration() not working #26722

Closed
1 of 4 tasks
ArgV04 opened this issue Jun 27, 2024 · 1 comment · Fixed by #27007
Closed
1 of 4 tasks

Nx 19.2.3 Angular 17.3.8 SSR with provideClientHydration() not working #26722

ArgV04 opened this issue Jun 27, 2024 · 1 comment · Fixed by #27007
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@ArgV04
Copy link

ArgV04 commented Jun 27, 2024

Current Behavior

SSR seems not to work when just creating a dump Angular app with SSR via: nx g application

When then trying to serve I run into this issue:
image

After changing this import:
import * as express from 'express'; to import express from 'express'; it seems to work

But when entering the app I see the warning of:

image

Expected Behavior

Serving a default generated Angular app with SSR should work out of the box!

GitHub Repo

No response

Steps to Reproduce

  1. nx g application (Angular with SSR enabled)

Nx Report

NX   Report complete - copy this into the issue template

Node   : 18.20.2
OS     : darwin-arm64
npm    : 10.5.0

nx                 : 19.2.3
@nx/js             : 19.2.3
@nx/jest           : 19.2.3
@nx/linter         : 19.2.3
@nx/eslint         : 19.2.3
@nx/workspace      : 19.2.3
@nx/angular        : 19.2.3
@nx/devkit         : 19.3.1
@nx/eslint-plugin  : 19.2.3
@nx/plugin         : 19.2.3
@nrwl/tao          : 19.2.3
@nx/web            : 19.2.3
@nx/webpack        : 19.2.3
typescript         : 5.3.3
---------------------------------------

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@AgentEnder AgentEnder added the scope: angular Issues related to Angular support in Nx label Jul 8, 2024
FrozenPandaz pushed a commit that referenced this issue Jul 22, 2024
…xecutors (#27007)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26722

(cherry picked from commit 4871642)
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants