Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx is not correctly detecting CI environment in Bamboo with Windows agents #26698

Closed
1 of 4 tasks
scottpledger opened this issue Jun 26, 2024 · 1 comment · Fixed by #26699
Closed
1 of 4 tasks

Nx is not correctly detecting CI environment in Bamboo with Windows agents #26698

scottpledger opened this issue Jun 26, 2024 · 1 comment · Fixed by #26699

Comments

@scottpledger
Copy link
Contributor

Current Behavior

Nx does not properly detect windows runners in Bamboo as being a CI environment, resulting in jobs stalling for hours until the Nx background service terminates.

Expected Behavior

Nx should not use a background service when executed from windows runners in Bamboo.

GitHub Repo

No response

Steps to Reproduce

  1. Set up Bamboo to test an Nx repository.
  2. Trigger a Bamboo build. It will take at least 3 hours to execute.

Nx Report

NX   Report complete - copy this into the issue template

Node   : 20.12.0
OS     : darwin-arm64
yarn   : 3.2.1

nx (global)    : 19.1.1
nx             : 19.3.1
@nx/js         : 19.3.1
@nx/jest       : 19.3.1
@nx/linter     : 19.3.1
@nx/eslint     : 19.3.1
@nx/workspace  : 19.3.1
@nx/devkit     : 19.3.1
@nx/esbuild    : 19.3.1
@nrwl/tao      : 19.3.1
typescript     : 5.3.3
---------------------------------------
Community plugins:
@nxify-io/graphql-codegen : 0.0.2

Failure Logs

No response

Package Manager Version

[email protected]

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Windows bamboo runners don't have the bamboo.buildKey environment variable, but rather they have the bamboo_buildKey environment variable.

@scottpledger scottpledger changed the title Nx is not correctly detecting CI environment in Bamboo with Windows runners Nx is not correctly detecting CI environment in Bamboo with Windows agents Jun 26, 2024
scottpledger added a commit to scottpledger/nx that referenced this issue Jun 26, 2024
This will treat the `bamboo_buildKey` environment variable as an indicator
that the current environment is a CI environment.

Closes nrwl#26698
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant