NX 19 - Expo migration fails if not using app.json

[minuz]

Current Behavior

When upgrading to NX 19 on a repo with @nx/expo, the migration update-19-0-0-change-webpack-to-metro fails to execute if the project is not using app.json to configure the expo project.
Expo offers the ability to use app.json | app.config.js | app.config.ts. See doco: https://docs.expo.dev/workflow/configuration/#properties

However, this migration explicitly targets only app.json

nx/packages/expo/src/migrations/update-19-0-0/change-webpack-to-metro.ts

Line 26 in 618096a

updateJson(tree, `${config.root}/app.json`, (appJson) => {

Expected Behavior

This should support all expo config files.

GitHub Repo

No response

Steps to Reproduce

1. Create an NX repo using NX < 19
2. Add an Expo project using @nx/expo
3. Change the generated app.json to app.config.{js,ts}
4. Run the migration using nx migrate latest && nx migrate --run-migrations
5. The aforementioned migration update-19-0-0-change-webpack-to-metro will fail

Nx Report

NX   Report complete - copy this into the issue template

Node   : 18.20.2
OS     : darwin-arm64
pnpm   : 8.15.8

nx                 : 19.0.6
@nx/js             : 19.0.6
@nx/jest           : 19.0.6
@nx/linter         : 19.0.6
@nx/eslint         : 19.0.6
@nx/workspace      : 19.0.6
@nx/detox          : 19.0.6
@nx/devkit         : 19.0.6
@nx/eslint-plugin  : 19.0.6
@nx/expo           : 19.0.6
@nx/plugin         : 19.0.6
@nx/react          : 19.0.6
@nx/rollup         : 19.0.6
@nrwl/tao          : 19.0.6
@nx/web            : 19.0.6
@nx/webpack        : 19.0.6
typescript         : 5.4.5
---------------------------------------
Local workspace plugins:
	 @xemplo-mobile/repo-helpers

Failure Logs

NX   Running 'pnpm install --no-frozen-lockfile' to make sure necessary packages are installed

Lockfile is up to date, resolution step is skipped
Already up to date

> [email protected] postinstall /Users/fernando.baba/Dev/repos/xemplo-mobile
> git config core.hooksPath ./.git-hooks

Done in 2.8s

 NX   Running migrations from 'migrations.json', with each applied in a dedicated commit


 NX   Failed to run update-19-0-0-change-webpack-to-metro from @nx/expo. This workspace is NOT up to date!


 NX   Cannot find apps/xemplo/app.json

Pass --verbose to see the stacktrace.

Command failed: pnpm exec nx _migrate --run-migrations --create-commits

 NX   Command failed: pnpm exec nx migrate --run-migrations --create-commits

Pass --verbose to see the stacktrace.

Command failed: /var/folders/w2/z287vrz12dg87__2klcv2gtr0000gp/T/tmp-68226-OBZCT359Znc4/node_modules/.bin/nx _migrate --run-migrations --create-commits

Package Manager Version

pnpm 8.15.8

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[magic-ksenia]

I'm facing the same issue running migrations in @nx/expo.
Updating to nx: 19.1.0
Node: 18.20.2
Yarn: 1.22.22
I need to use dinamic app.config.js.

...
 NX   Failed to run update-19-0-0-change-webpack-to-metro from @nx/expo. This workspace is NOT up to date!

 NX   Cannot find apps/vision-app/app.json

Pass --verbose to see the stacktrace.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Command failed: yarn nx _migrate --run-migrations
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

 NX   Command failed: yarn nx migrate --run-migrations 

[xiongemi]

fixed in pr #26137

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.