NX Daemon Server crashing when running pnpm install
#23031
Assignees
Labels
Comments
|
Downgrade pnpm to v8, it will solve the issue
|
|
Still see this on 19.0.3 |
Cammisuli
added a commit
that referenced
this issue
May 17, 2024
Cammisuli
added a commit
that referenced
this issue
May 17, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> When there are watch event changes, and we filter them all out, we get an empty `changedEvents` array. There were previous checks that had a `!changedEvents.length` condition that resolved to true when the length was 0. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We now check to see if `err` is set before triggering the error branch ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23031
FrozenPandaz
pushed a commit
that referenced
this issue
May 21, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> When there are watch event changes, and we filter them all out, we get an empty `changedEvents` array. There were previous checks that had a `!changedEvents.length` condition that resolved to true when the length was 0. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We now check to see if `err` is set before triggering the error branch ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23031 (cherry picked from commit 3bbc964)
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
Current Behavior
Subsequent to #21492, we upgraded to 18.3.4 which contains the fix, and removed our hacky workaround where we call
nx resetafter runningpnpm installdue to the daemon serverpanicing in the Rust code.We now see a different error:
Expected Behavior
We would expect the daemon not to crash when running
pnpm installGitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
pnpm 9.0.2
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: