You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you add a "listen" option to the config.yml for the purposes of running Verdaccio on https, the setting is ignored. The reason is because the "port" option from the nx settings for Verdaccio are required (and have a default) and always are used instead. This results in Verdaccio running with --listen PORT.
The related code is:
function createVerdaccioOptions(
options: VerdaccioExecutorSchema,
workspaceRoot: string
) {
const verdaccioArgs: string[] = [];
if (options.port) {
verdaccioArgs.push('--listen', options.port.toString());
}
options.port will always have a value (because of the default in schema.json, so the "listen" value in the config.yml is always ignored it seems.
Expected Behavior
I expect the "listen" setting to be used.
GitHub Repo
No response
Steps to Reproduce
Remove the "port" setting from the nx settings options for Verdaccio
Create a ".verdaccio/config.yml" and add a "listen" setting like listen: "https://localhost:4444"
Reference the config in the nx Verdaccio settings options with `"config": ".verdaccio/config.yml"
Start Verdaccio with nx and note that it still starts on http with the default 4873 port
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
## Current Behavior
<!-- This is the behavior we have today -->
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
- remove default port for verdaccio so it can take port from config file
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#23007
Current Behavior
If you add a "listen" option to the config.yml for the purposes of running Verdaccio on https, the setting is ignored. The reason is because the "port" option from the nx settings for Verdaccio are required (and have a default) and always are used instead. This results in Verdaccio running with
--listen PORT
.The related code is:
options.port will always have a value (because of the default in schema.json, so the "listen" value in the config.yml is always ignored it seems.
Expected Behavior
I expect the "listen" setting to be used.
GitHub Repo
No response
Steps to Reproduce
listen: "https://localhost:4444"
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: