Vue typechecking is incorrect when setting skipTypeCheck: false for @nx/vite:build executor

[domantas-simplex]

Current Behavior

Running nx run <vue-project-name>:build on brand new vue project with "skipTypeCheck": false produces typescript errors. It doesn't catch typescript errors in *.vue files either.

Expected Behavior

nx run <vue-project-name>:build with "skipTypeCheck": false should produce no errors on brand new vue project and should typecheck not only *.ts files, but *.vue files as well.

GitHub Repo

https://github.com/domantas-simplex/nx-vue-typecheck-monorepo

Steps to Reproduce

git clone [email protected]:domantas-simplex/nx-vue-typecheck-monorepo.git && cd nx-vue-typecheck-monorepo && npm i && npx nx run typechecking-test:build

or

1. git clone [email protected]:domantas-simplex/nx-vue-typecheck-monorepo.git
2. cd nx-vue-typecheck-monorepo
3. npm i
4. npx nx run typechecking-test:build

Nx Report

Node   : 20.9.0
   OS     : darwin-arm64
   npm    : 10.1.0
   
   nx                 : 17.1.2
   @nx/js             : 17.1.2
   @nx/linter         : 17.1.2
   @nx/eslint         : 17.1.2
   @nx/workspace      : 17.1.2
   @nx/devkit         : 17.1.2
   @nx/eslint-plugin  : 17.1.2
   @nx/playwright     : 17.1.2
   @nrwl/tao          : 17.1.2
   @nx/vite           : 17.1.2
   @nx/vue            : 17.1.2
   @nx/web            : 17.1.2
   typescript         : 5.2.2

Failure Logs

No response

Package Manager Version

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

Looks like typechecking is performed with usual typescript instead of vue-tsc.

nx/packages/vite/src/utils/executor-utils.ts

Line 16 in 96043fb

const result = await runTypeCheck({

nx/packages/js/src/utils/typescript/run-type-check.ts

Lines 81 to 85 in 96043fb

	export async function runTypeCheck(
	options: TypeCheckOptions
	): Promise<TypeCheckResult> {
	const { ts, workspaceRoot, cacheDir, config, compilerOptions } =
	await setupTypeScript(options);

nx/packages/js/src/utils/typescript/run-type-check.ts

Lines 119 to 120 in 96043fb

	async function setupTypeScript(options: TypeCheckOptions) {
	const ts = await import('typescript');

Vue projects should be typechecked with vue-tsc - https://www.npmjs.com/package/vue-tsc

Example of typechecking script: https://github.com/vuejs/create-vue-templates/blob/371a1995e07a71328c3163917479a9e30d9ba1a4/typescript/package.json#L10

[github-actions]

This issue has been automatically marked as stale because it hasn't had any activity for 6 months.
Many things may have changed within this time. The issue may have already been fixed or it may not be relevant anymore.
If at this point, this is still an issue, please respond with updated information.
It will be closed in 21 days if no further activity occurs.
Thanks for being a part of the Nx community! 🙏

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.