Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx g @nx/next:library ui-components adds cypress + swc to package.json #19258

Closed
1 of 4 tasks
PaulMest opened this issue Sep 20, 2023 · 2 comments · Fixed by #19587
Closed
1 of 4 tasks

nx g @nx/next:library ui-components adds cypress + swc to package.json #19258

PaulMest opened this issue Sep 20, 2023 · 2 comments · Fixed by #19587
Assignees
Labels
outdated scope: nextjs Issues related to NextJS support for Nx type: bug

Comments

@PaulMest
Copy link

PaulMest commented Sep 20, 2023

Current Behavior

$ nx g @nx/next:library ui-components adds several unnecessary dependencies to package.json.

Expected Behavior

$ nx g @nx/next:library ui-components should not change any dependencies in my project. I already have nextjs configured and I use Playwright (not Cypress).

GitHub Repo

No response

Steps to Reproduce

  1. npx create-nx-workspace@latest
  2. nx g @nx/next:app web
  3. git add . && git commit -m "next app"
  4. nx g @nx/next:library ui-components
  5. Look at the package.json and you'll see package.json has new unnecessary dependencies
image

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 20.6.1
   OS     : darwin-arm64
   pnpm   : 8.7.6

   nx (global)        : 16.8.1
   nx                 : 16.8.1
   @nx/js             : 16.8.1
   @nx/jest           : 16.8.1
   @nx/linter         : 16.8.1
   @nx/workspace      : 16.8.1
   @nx/devkit         : 16.8.1
   @nx/eslint-plugin  : 16.8.1
   @nx/next           : 16.8.1
   @nx/playwright     : 16.8.1
   @nx/react          : 16.8.1
   @nrwl/tao          : 16.8.1
   typescript         : 5.1.6

Failure Logs

No response

Package Manager Version

pnpm 8.7.6

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@PaulMest
Copy link
Author

Thank you for the fix and the test!

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: nextjs Issues related to NextJS support for Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants