feat(webpack): move module federation utils to webpack #18996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
jaysoo,
FrozenPandaz,
vsavkin and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
730ceec to
ab0601c
Compare
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
ab0601c to
4b35184
Compare
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
4b35184 to
e8a226e
Compare
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
e8a226e to
2a096f2
Compare
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
2a096f2 to
515d431
Compare
jaysoo
approved these changes
Sep 6, 2023
AgentEnder
approved these changes
Sep 6, 2023
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
515d431 to
2d09112
Compare
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
2d09112 to
d69a911
Compare
FrozenPandaz
requested changes
Sep 7, 2023
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
d69a911 to
b1f3506
Compare
Coly010
force-pushed
the
mf/move-utils-to-webpack
branch
from
b1f3506 to
4c536af
Compare
FrozenPandaz
approved these changes
Sep 8, 2023
|
|
||
| let { readJsonFile, joinPathFragments, workspaceRoot, readModulePackageJson } = | ||
| requireNx(); | ||
| let { readModulePackageJson } = requireNx(); |
There was a problem hiding this comment.
You changed other imports other than this. Can you change this too in a followup please?
This should come from nx directly.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our Module Federation utilities currently live in
@nx/devkit. They were placed here for convenience during the previous effort on MF.Expected Behavior
Our Module Federation utilities will live in
@nx/webpackwhich makes more sense as we currently, and for the foreseeable future, only support Webpack Module Federation.This will also remove them from the
@nx/devkitPublic API, usage of which has been deprecated already.Related Issue(s)
Fixes #