Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @angular/pwa in migrate command #18731

Closed
dtslvr opened this issue Aug 21, 2023 · 2 comments · Fixed by #18736
Closed

Upgrade @angular/pwa in migrate command #18731

dtslvr opened this issue Aug 21, 2023 · 2 comments · Fixed by #18736
Assignees
@Coly010
Labels
outdated scope: angular Issues related to Angular support in Nx type: feature

Comments

@dtslvr
Copy link
Contributor

dtslvr commented Aug 21, 2023

Description

When I run yarn nx migrate latest in a Nx workspace containing an Angular project, all dependencies are updated in the package.json except @angular/pwa.

Motivation

It is often forgotten that @angular/pwa also needs to be updated to be compatible with @angular/core.
@leosvelperez leosvelperez added the scope: angular Issues related to Angular support in Nx label Aug 21, 2023
@Coly010 Coly010 self-assigned this Aug 21, 2023
@Coly010 Coly010 mentioned this issue Aug 21, 2023
Merged
Coly010 added a commit that referenced this issue Aug 21, 2023
@Coly010
fix(angular): add @angular/pwa to migrations #18731
85ab89c
Coly010 added a commit that referenced this issue Aug 21, 2023
@Coly010
fix(angular): add @angular/pwa to migrations #18731
d2ec653
Coly010 added a commit that referenced this issue Aug 22, 2023
@Coly010
fix(angular): add @angular/pwa to migrations #18731 (#18736)
791171e
@dtslvr
Copy link
Contributor Author

dtslvr commented Aug 22, 2023

Awesome! Thank you @Coly010 🙌🏻

FrozenPandaz pushed a commit that referenced this issue Aug 23, 2023
@Coly010 @FrozenPandaz
fix(angular): add @angular/pwa to migrations #18731 (#18736)
7859d45 
(cherry picked from commit 791171e)
@timonmasberg timonmasberg mentioned this issue Aug 24, 2023
Merged
@github-actions github-actions bot mentioned this issue Aug 24, 2023
Closed
@timonmasberg timonmasberg mentioned this issue Sep 7, 2023
Closed
@github-actions github-actions bot mentioned this issue Sep 7, 2023
Open
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Coly010 Coly010

Labels
outdated scope: angular Issues related to Angular support in Nx type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(angular): add @angular/pwa to migrations #18731 nrwl/nx
3 participants
@dtslvr @leosvelperez @Coly010