Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): Vite 5 compatibility #18535

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

benmccann
Copy link
Contributor

Current Behavior

Currently doing a require of vite

Expected Behavior

Do an import of vite to use the ESM version as the CJS version is likely to be dropped or cause a warning in the next release

@benmccann benmccann requested review from a team as code owners August 8, 2023 18:36
@benmccann benmccann requested a review from mandarini August 8, 2023 18:36
@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 6:42pm

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Aug 8, 2023
@barbados-clemens barbados-clemens merged commit 38fec9c into nrwl:master Aug 8, 2023
@benmccann benmccann deleted the vite5 branch August 8, 2023 19:33
@benmccann
Copy link
Contributor Author

thank you for the help!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants