fix(react): add typings to types instead of files #18501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When you create a react app inside
tsconfig.app.json
andtsconfig.spec.json
there are hardcoded references to typings insidenode_modules
.If you use Yarn PnP these hardcoded references would fail since
node_modules
do not exist.Expected Behavior
This PR removes the references from
tsconfig
and adds them tocompilerOptions.types
.That way there would be no need to have hardcoded references and they would be automatically picked up during bundling since they are declared in
types
.