Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add typings to types instead of files #18501

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

When you create a react app inside tsconfig.app.json and tsconfig.spec.json there are hardcoded references to typings inside node_modules.

If you use Yarn PnP these hardcoded references would fail since node_modules do not exist.

Expected Behavior

This PR removes the references from tsconfig and adds them to compilerOptions.types .
That way there would be no need to have hardcoded references and they would be automatically picked up during bundling since they are declared in types.

@ndcunningham ndcunningham requested a review from a team as a code owner August 4, 2023 21:47
@ndcunningham ndcunningham requested a review from jaysoo August 4, 2023 21:47
@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 10:07pm

@meeroslav meeroslav merged commit 85f4737 into nrwl:master Aug 7, 2023
@ndcunningham ndcunningham deleted the fix/update-react-types branch August 9, 2023 13:20
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants