-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundling): generate matching d.ts files for rollup #18342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
feat/rollup-dts
branch
2 times, most recently
from
July 27, 2023 15:36
a6a74a5
to
8076507
Compare
ndcunningham
approved these changes
Jul 27, 2023
This was referenced Aug 1, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the rollup executor such that it produces
.d.ts
files matching the output bundle.It also:
[name].esm.js
and[name].cjs.js
naming convention so Node/TSC doesn't have problems matching CJS files with their.d.ts
file -- subsequent requires/imports from.cjs
requires file extension to be included, which puts the burden on lib authors.exports
field to align with current best practice (import
+default
, notypes
)So a user using dual formats will see:
The types are inferred from file names e.g.
index.cjs.d.ts
orindex.esm.d.ts
.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #