Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): server executor https prop as object #18048

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat(vite): server executor https prop as object #18048

merged 1 commit into from
Jul 10, 2023

Conversation

josokinas
Copy link
Contributor

Current Behavior

Vite's "dev-server" and "preview-server" property https accept only a boolean.

Expected Behavior

Vite's "dev-server" and "preview-server" property https accept a boolean or an object.

Related Issue(s)

Fixes #17835

@josokinas josokinas requested review from a team as code owners July 10, 2023 09:40
@josokinas josokinas requested review from mandarini and juristr July 10, 2023 09:40
@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 9:43am

@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ce88b4f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mandarini mandarini merged commit 6bf3dc9 into nrwl:master Jul 10, 2023
@josokinas josokinas deleted the fix/vite-executors-https branch July 10, 2023 11:13
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite:dev-server option https as options object
2 participants