Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite:dev-server option https as options object #17835

Closed
1 of 4 tasks
josokinas opened this issue Jun 28, 2023 · 2 comments · Fixed by #18048
Closed
1 of 4 tasks

vite:dev-server option https as options object #17835

josokinas opened this issue Jun 28, 2023 · 2 comments · Fixed by #18048
Labels
outdated scope: bundlers Issues related to webpack, rollup type: bug

Comments

@josokinas
Copy link
Contributor

Current Behavior

The option https for vite:dev-server is accepting boolean only.

Expected Behavior

The option https for vite:dev-server is accepting boolean AND options object, as described on Vite docs: https://vitejs.dev/config/server-options.html#server-https

GitHub Repo

No response

Steps to Reproduce

  1. Configure a project to use @nx/vite:dev-server executor for "serve" task
  2. Configure "options" object, set "https" option as {}
  3. Serve the app
Screenshot 2023-06-28 at 15 18 39

Nx Report

Node   : 18.16.0
   OS     : darwin arm64
   yarn   : 3.5.0
   Hasher : Native
   
   nx                 : 16.3.2
   @nx/js             : 16.3.2
   @nx/jest           : 16.3.2
   @nx/linter         : 16.3.2
   @nx/workspace      : 16.3.2
   @nx/cypress        : 16.3.2
   @nx/devkit         : 16.3.2
   @nrwl/devkit       : 16.1.0
   @nx/eslint-plugin  : 16.3.2
   @nx/plugin         : 16.3.2
   @nx/react          : 16.3.2
   @nx/storybook      : 16.3.2
   @nrwl/tao          : 16.3.2
   @nx/vite           : 16.3.2
   @nx/web            : 16.3.2
   typescript         : 5.1.3
   ---------------------------------------
   Community plugins:
   @nx-aws-plugin/nx-aws-cache : 3.0.0
   nx-stylelint                : 14.0.2
   ---------------------------------------
   Local workspace plugins:
   	 @k/tm-shared
   	 @k/tm-rules
   	 @k/tooling
   	 @k/ui
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nrwl/[email protected]
   
   To fix this, run `nx migrate [email protected]`

Failure Logs

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@FrozenPandaz FrozenPandaz added the scope: bundlers Issues related to webpack, rollup label Jun 28, 2023
@josokinas
Copy link
Contributor Author

Please note that same applies to @nx/vite:preview-server executor.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: bundlers Issues related to webpack, rollup type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants