Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): set localhost as hostname default #17856

Merged

Conversation

myabeaver
Copy link
Contributor

closed #17852

@myabeaver myabeaver requested a review from a team as a code owner June 29, 2023 12:34
@myabeaver myabeaver requested a review from mandarini June 29, 2023 12:34
@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 2:26pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8d1b017. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this to schema.json as a default?

@myabeaver myabeaver force-pushed the set-localhost-as-hostname-default branch from a8a0241 to 863c84a Compare June 29, 2023 15:35
@myabeaver
Copy link
Contributor Author

Can you also add this to schema.json as a default?

Done

Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ndcunningham
Copy link
Contributor

ndcunningham commented Jun 29, 2023

documentation has been updated can you run pnpm documentation and commit the changes as well so that it shows on nx.dev @myasteiner
Also run pnpx nx format if you have not already.

@ndcunningham ndcunningham force-pushed the set-localhost-as-hostname-default branch from 863c84a to 8d1b017 Compare June 30, 2023 14:23
@ndcunningham ndcunningham requested a review from a team as a code owner June 30, 2023 14:23
@ndcunningham ndcunningham requested a review from juristr June 30, 2023 14:23
@ndcunningham ndcunningham merged commit 88c655f into nrwl:master Jun 30, 2023
FrozenPandaz pushed a commit that referenced this pull request Jun 30, 2023
meeroslav added a commit to meeroslav/nx that referenced this pull request Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next server executor does not have default localhost hostname anymore
2 participants