fix(nextjs): set localhost as hostname default (#17856)

nrwl · Jun 30, 2023 · 88c655f · 88c655f · vercel · Jun 30, 2023
1 parent 4d76d0c
commit 88c655f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/docs/generated/packages/next/executors/server.json b/docs/generated/packages/next/executors/server.json
@@ -41,7 +41,8 @@
       },
       "hostname": {
         "type": "string",
-        "description": "Hostname on which the application is served."
+        "description": "Hostname on which the application is served.",
+        "default": "localhost"
       },
       "buildLibsFromSource": {
         "type": "boolean",

diff --git a/packages/next/src/executors/server/schema.json b/packages/next/src/executors/server/schema.json
@@ -38,7 +38,8 @@
     },
     "hostname": {
       "type": "string",
-      "description": "Hostname on which the application is served."
+      "description": "Hostname on which the application is served.",
+      "default": "localhost"
     },
     "buildLibsFromSource": {
       "type": "boolean",

diff --git a/packages/next/src/executors/server/server.impl.ts b/packages/next/src/executors/server/server.impl.ts
@@ -30,7 +30,7 @@ export default async function* serveExecutor(
   );
   const projectRoot = context.workspace.projects[context.projectName].root;
 
-  const { port, keepAliveTimeout, hostname } = options;
+  const { port, keepAliveTimeout, hostname = 'localhost' } = options;
 
   // This is required for the default custom server to work. See the @nx/next:app generator.
   process.env.NX_NEXT_DIR = projectRoot;