Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nest): added es2021 support for nest generators #17726

Merged

Conversation

gperdomor
Copy link
Contributor

@gperdomor gperdomor commented Jun 22, 2023

Current Behavior

Nest is using es2015 as ts target

Expected Behavior

With migration to Nest 10, official templates now uses es2021

Related Issue(s)

#17681
#17690

@gperdomor gperdomor requested a review from a team as a code owner June 22, 2023 13:15
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 9:05pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3bdf15d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@gperdomor gperdomor requested a review from a team as a code owner June 22, 2023 13:51
@gperdomor gperdomor requested a review from bcabanes June 22, 2023 13:51
@gperdomor gperdomor force-pushed the feature/nest-10-es2021-support branch from c08eaaa to e0748e0 Compare June 22, 2023 14:21
@gperdomor gperdomor changed the title feat(nest): es2021 support feat(nest): added es2021 support for nest generators Jun 22, 2023
@barbados-clemens barbados-clemens dismissed their stale review June 22, 2023 17:20

approved by accident, still want to locally test

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change for the description since we bumping the target.

packages/nest/src/generators/library/schema.json Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants