Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-nx-workspace does not generate Dockerfile (node-standalone/nest) #17343

Closed
2 of 4 tasks
Ionaru opened this issue May 31, 2023 · 7 comments · Fixed by #27153
Closed
2 of 4 tasks

create-nx-workspace does not generate Dockerfile (node-standalone/nest) #17343

Ionaru opened this issue May 31, 2023 · 7 comments · Fixed by #27153
Assignees
@ndcunningham
Labels
outdated scope: node Issues related to Node, Express, NestJS support for Nx type: bug

Comments

@Ionaru
Copy link

Ionaru commented May 31, 2023 •
edited
Loading

Current Behavior

No Dockerfile is generated when running the create-nx-workspace command using NestJS as the framework and the --docker option enabled.

Expected Behavior

A Dockerfile should be created, allowing the application to run in docker, OR the --docker option should not be allowed in this configuration and the CLI should not ask whether to generate a Dockerfile when running without the --docker option defined.

image

GitHub Repo

N/A

Steps to Reproduce

  1. Run npx create-nx-workspace@latest new-workspace --nxCloud false --preset node-standalone --framework nest --docker true
  2. Inspect the generated files, no Dockerfile is present.

Nx Report

N/A

Failure Logs

N/A

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@AgentEnder AgentEnder added the scope: node Issues related to Node, Express, NestJS support for Nx label Jun 1, 2023
@kobyzskyi
Copy link

The same story for macOS.

@pde201
Copy link

pde201 commented Aug 15, 2023

Is there an ETA for this bug?

@alexmacavei
Copy link

Yep, same issue here.

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it hasn't had any activity for 6 months.
Many things may have changed within this time. The issue may have already been fixed or it may not be relevant anymore.
If at this point, this is still an issue, please respond with updated information.
It will be closed in 21 days if no further activity occurs.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label May 15, 2024
@github-actions github-actions bot removed the stale label May 16, 2024
@pkimtani
Copy link

Same issue here. Running on MacOS (ARM CPU).

@sir-captainmorgan21
Copy link
Contributor

Ya same here

ndcunningham added a commit that referenced this issue Jul 26, 2024
@ndcunningham
fix(node): Ensure docker file can be generated when nest framework is…
618d1c1 
… set

closes: #17343
@ndcunningham ndcunningham mentioned this issue Jul 26, 2024
Merged
ndcunningham added a commit that referenced this issue Jul 26, 2024
@ndcunningham
fix(node): Ensure docker file can be generated when nest framework is…
250cf32 
… set

closes: #17343
FrozenPandaz pushed a commit that referenced this issue Jul 30, 2024
@ndcunningham @FrozenPandaz
fix(node): Ensure docker file is generated when nest framework is sup…
a6b1b7d 
…plied (#27153)

When we generate a nest application and supply the `--docker` flag it
should generate a DockerFile.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Currently, no DockerFile is created.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

A DockerFile to be created.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #17343

(cherry picked from commit bff23d1)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ndcunningham ndcunningham

Labels
outdated scope: node Issues related to Node, Express, NestJS support for Nx type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node): Ensure docker file is generated when nest framework is supplied nrwl/nx
8 participants
@ndcunningham @Ionaru @AgentEnder @sir-captainmorgan21 @kobyzskyi @pkimtani @alexmacavei @pde201