Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): add babel root-mode option to withNx plugin #17286

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 29, 2023

This PR adds the babelUpwardRootMode option to withNx plugin, for use in next.config.js file. This is false by default, and users will need to opt into it if they want to maintain the monorepo behavior of loading all individual .babelrc files.

Note: We don't want the root mode behavior by default because it can lead to inconsistencies between apps and libs. If a lib needs certain babel plugins to work, then the app need specify it in its own .babelrc file.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 2:02pm

@jaysoo jaysoo marked this pull request as ready for review May 29, 2023 13:43
@jaysoo jaysoo requested review from a team as code owners May 29, 2023 13:43
@jaysoo jaysoo requested review from xiongemi and juristr May 29, 2023 13:43
@ndcunningham ndcunningham merged commit 7dd8fb6 into nrwl:master May 29, 2023
@jaysoo jaysoo deleted the feat/nextjs-add-babel-root-mode-option branch May 29, 2023 15:08
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants