Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): make sure new tsconfig exists before adding ref #17147

Merged

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

nx/cypress v16.2.0 migration might add a project reference to a tsconfig file that doesn't exist

Expected Behavior

migration does not add references to files that don't exist

Related Issue(s)

Fixes #17120

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 7:07pm

@barbados-clemens barbados-clemens self-assigned this May 22, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label May 22, 2023
@nx-cloud
Copy link

nx-cloud bot commented May 22, 2023

@barbados-clemens barbados-clemens force-pushed the fix/cy-tsconfig-only-if-exists branch from ac5be44 to 111eb81 Compare May 24, 2023 18:58
@barbados-clemens barbados-clemens marked this pull request as ready for review May 24, 2023 20:13
@barbados-clemens barbados-clemens enabled auto-merge (squash) May 24, 2023 20:41
@AgentEnder AgentEnder disabled auto-merge May 25, 2023 15:36
@AgentEnder AgentEnder merged commit 15ea10e into nrwl:master May 25, 2023
@barbados-clemens barbados-clemens deleted the fix/cy-tsconfig-only-if-exists branch May 25, 2023 16:11
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress migration in 16.2 add reference to not existing tsconfig
2 participants