Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress migration in 16.2 add reference to not existing tsconfig #17120

Closed
1 of 4 tasks
DaSchTour opened this issue May 20, 2023 · 2 comments · Fixed by #17147
Closed
1 of 4 tasks

Cypress migration in 16.2 add reference to not existing tsconfig #17120

DaSchTour opened this issue May 20, 2023 · 2 comments · Fixed by #17147
Assignees
Labels
outdated scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug

Comments

@DaSchTour
Copy link
Contributor

Current Behavior

Migration was not available before. The cypress migrations introduced in #16651 create a reference to a non existing tsconfig

Expected Behavior

Migration should not point to not exisiting tsconfig

GitHub Repo

No response

Steps to Reproduce

  1. Run 16.2 migrations

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 19.6.1
   OS     : darwin x64
   npm    : 9.4.0
   Hasher : Native
   
   nx                 : 16.2.1
   @nx/js             : 16.2.1
   @nx/jest           : 16.2.1
   @nx/linter         : 16.2.1
   @nx/workspace      : 16.2.1
   @nx/angular        : 16.2.1
   @nx/cypress        : 16.2.1
   @nx/devkit         : 16.2.1
   @nx/esbuild        : 16.2.1
   @nx/eslint-plugin  : 16.2.1
   @nx/nest           : 16.2.1
   @nx/node           : 16.2.1
   @nx/plugin         : 16.2.1
   @nx/rollup         : 16.2.1
   @nrwl/tao          : 16.2.1
   @nx/webpack        : 16.2.1
   nx-cloud           : 16.0.5
   typescript         : 5.0.4
   ---------------------------------------
   Community plugins:
   @compodoc/compodoc               : 1.1.19
   @fortawesome/angular-fontawesome : 0.13.0
   @ionic/angular                   : 6.7.4
   @jscutlery/semver                : 3.0.0
   @nestjs-fixed/ng-universal       : 7.0.1
   @ngneat/spectator                : 14.0.0
   @ngrx/component                  : 16.0.0
   @ngrx/component-store            : 16.0.0
   @ngrx/data                       : 16.0.0
   @ngrx/effects                    : 16.0.0
   @ngrx/entity                     : 16.0.0
   @ngrx/eslint-plugin              : 16.0.0
   @ngrx/router-store               : 16.0.0
   @ngrx/schematics                 : 16.0.0
   @ngrx/store                      : 16.0.0
   @ngrx/store-devtools             : 16.0.0
   @nguniversal/builders            : 16.0.1
   @nguniversal/common              : 16.0.1
   @nguniversal/express-engine      : 16.0.1
   @nx-tools/nx-container           : 4.0.3
   @nxext/capacitor                 : 15.7.0
   @nxext/ionic-angular             : 15.7.0
   @trellisorg/make-buildable       : 0.0.12
   @twittwer/compodoc               : 1.9.0
   apollo-angular                   : 5.0.0
   ng-mocks                         : 14.10.1
   ngx-build-plus                   : 16.0.0
   ngx-deploy-npm                   : 6.0.0
   nx-stylelint                     : 15.0.0
   ---------------------------------------
   Local workspace plugins:
   	 @footage.one/workspace-plugin
   	 @footage.one/nx-version

Failure Logs

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Index: apps/asset-manager-e2e/tsconfig.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/apps/…-e2e/tsconfig.json b/apps/…-e2e/tsconfig.json
--- a/apps/…-e2e/tsconfig.json	(revision 386063253b1d7088fdabb00402ba43ee571847d5)
+++ b/apps/…-e2e/tsconfig.json	(date 1684571636306)
@@ -15,5 +15,10 @@
     "strictInjectionParameters": true,
     "strictInputAccessModifiers": true,
     "strictTemplates": true
-  }
+  },
+  "references": [
+    {
+      "path": "./cypress/tsconfig.json"
+    }
+  ]
 }

@AgentEnder AgentEnder added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label May 20, 2023
@barbados-clemens
Copy link
Contributor

@DaSchTour do you have an example of the tsconfig and project.json of the project where this happened to?

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants