js: silently fails to run a file

[Maxim-Mazurok]

Current Behavior

I have this:

  "targets": {
    "build": {
      "executor": "@nx/js:tsc",
      "outputs": ["{options.outputPath}"],
      "options": {
        "outputPath": "dist/packages/analyze",
        "main": "packages/analyze/src/index.ts",
        "tsConfig": "packages/analyze/tsconfig.lib.json",
        "assets": []
      }
    },
    "run": {
      "executor": "@nx/js:node",
      "options": {
        "buildTarget": "analyze:build",
        "watch": false
      }
    },

When I run nx run analyze:run - it says "> NX Successfully ran target run for project analyze" however the actual file is not being run. I can confirm this by throwing in the file, logging to a file, etc.

I believe it's because in #16924 in node.impl.ts there's no handling of non-zero exit codes in task.childProcess.once('exit', (code) => { handler.

After som debugging, I found out that it is trying to run main.js file - the default one.

Previously before #16924 the file to run was determined by NX_FILE_TO_RUN: event.outfile.

Now I have to add "outputFileName": "src/index.js", to my build target options which isn't very nice.

Expected Behavior

1. When running js file fails - it shows the error
2. I don't have to specify outputFileName in build target in order to run it (also main.js doesn't seem like a good default because even if I had main.ts - I'd still have to add src/ prefix)

GitHub Repo

No response

Steps to Reproduce

See above

Nx Report

Node   : 19.8.1
   OS     : win32 x64
   npm    : 9.5.1
   Hasher : Native

   nx                 : 16.2.1
   @nx/js             : 16.2.1
   @nx/jest           : 16.2.1
   @nx/linter         : 16.2.1
   @nx/workspace      : 16.2.1
   @nx/devkit         : 16.2.1
   @nx/eslint-plugin  : 16.2.1
   @nx/plugin         : 16.2.1
   @nrwl/tao          : 16.2.1
   @nx/vite           : 16.2.1
   nx-cloud           : 16.0.5
   typescript         : 5.0.4

Failure Logs

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[Maxim-Mazurok]

A temporary workaround is to use 16.0.1 where import paths weren't broken yet (#16911)

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.