dependsOn shorthand broken when target name matches name of a project in the same repo.

[acburdine]

Current Behavior

Noticed this after the Nx v16 update - a number of our dependsOn configurations in various projects in our Nx monorepo were failing to run.

Example: A given repo has two projects: a and core. Project a has a build target and a core target. The build target has "dependsOn": ["core"] set, however whenever nx build a is run, the core target is not invoked. Caching isn't the cause here as far as I can tell, given that the core target is not listed under cacheableOperations in nx.json.

Using the slightly more explicit configuration of "dependsOn": [{ "target": "core" }] works as expected.

Expected Behavior

Prior to the Nx v16 update, the core target in the above example would be correctly invoked before the build target.

GitHub Repo

https://github.com/acburdine/nx-dependson-repro

Steps to Reproduce

1. Clone the above repo
2. Run nx build test, see that the core target is not invoked, though the core-2 target is invoked.
3. Run nx build test-2, see that both the core and core-2 targets are invoked.

Nx Report

Node   : 18.15.0
OS     : darwin x64
npm    : 9.6.3
Hasher : Native

nx (global)    : 16.1.3
nx             : 16.1.4
@nx/js         : 16.1.4
@nx/workspace  : 16.1.4
@nx/devkit     : 16.1.4
@nrwl/tao      : 16.1.4
typescript     : 5.0.4

Failure Logs

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

If I had to guess, this may be related to the changes in v16 allowing for dependsOn configurations to specify explicit projects, rather than just dependencies or self.

[acburdine]

After poking around in the code - I figured out where the issue is, and after reading it realized it may be an intentional change. That said, if it is an intentional change, it should be better documented to avoid folks running into this issue.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.