feat(core): add skipTypeCheck option to rollup plugin options

[marwan38]

Current Behavior

Can't disable the rollup typescript plugin type checker

Expected Behavior

Allow users to disable it if needed

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 6, 2023 11:11am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 230c58a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=842c41232d7c072383305c25e44c7d80b7bf725b --head=230c58a12dcd484b09934b80d986897bc76f36e5 --parallel=1
• nx affected --target=test --base=842c41232d7c072383305c25e44c7d80b7bf725b --head=230c58a12dcd484b09934b80d986897bc76f36e5 --parallel=1
• nx affected --target=build --base=842c41232d7c072383305c25e44c7d80b7bf725b --head=230c58a12dcd484b09934b80d986897bc76f36e5 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners --parallel=1 --no-dte
• nx affected --target=lint --base=842c41232d7c072383305c25e44c7d80b7bf725b --head=230c58a12dcd484b09934b80d986897bc76f36e5 --parallel=3
• nx-cloud record -- nx format:check --base=842c41232d7c072383305c25e44c7d80b7bf725b --head=230c58a12dcd484b09934b80d986897bc76f36e5
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[mandarini]

Can you add this extra option to the schema.json as well, and then run pnpm documentation? Thanks!

[marwan38]

@mandarini Thanks for getting back to me so quickly. I've added it to the schema and generated the docs. I copied over the exact schema definition from esbuild and swc. No idea what x-priority is, but, if both esbuild and swc have it set to important I thought that's what I should be doing.

[mandarini]

Hi there @marwan38 ! Thanks for updating the code! Can you please squash the commits and remove the x-priority attribute? We add this as important usually for required values or values we want to bring attention to, so that they are pushed at the top of the executor options list. The new option you added will still show in the list, just not at the top!

I tried to make these changes myself to your repo, but I did not have permission to push :)

[marwan38]

@mandarini all done. thanks again for walking me through it :)

[mandarini]

All is great now! Thanks! :) However, unfortunately, a new PR got merged and there are some conflicts with your branch, so you need to rebase with latest master. I would do it for you, but I don't have permission to push to your fork :( You can "allow edits by maintainers" in your fork, if you want!

[marwan38]

@mandarini Done!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.