Skip to content

Commit

Permalink
feat(core): add skipTypeCheck option to rollup plugin options (#16710)
Browse files Browse the repository at this point in the history
(cherry picked from commit 878df9a)
  • Loading branch information
marwan38 authored and FrozenPandaz committed May 8, 2023
1 parent 1488728 commit 4233eff
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 1 deletion.
5 changes: 5 additions & 0 deletions docs/generated/packages/rollup/executors/rollup.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@
"type": "boolean",
"description": "Generate package.json with 'exports' field. This field defines entry points in the package and is used by Node and the TypeScript compiler.",
"default": false
},
"skipTypeCheck": {
"type": "boolean",
"description": "Whether to skip TypeScript type checking.",
"default": false
}
},
"required": ["tsConfig", "main", "outputPath"],
Expand Down
1 change: 1 addition & 0 deletions packages/rollup/src/executors/rollup/lib/normalize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export function normalizeRollupExecutorOptions(
project,
projectRoot,
outputPath,
skipTypeCheck: options.skipTypeCheck || false,
};
}

Expand Down
2 changes: 1 addition & 1 deletion packages/rollup/src/executors/rollup/rollup.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export function createRollupOptions(
json(),
(useTsc || useBabel) &&
require('rollup-plugin-typescript2')({
check: true,
check: !options.skipTypeCheck,
tsconfig: options.tsConfig,
tsconfigOverride: {
compilerOptions: createTsCompilerOptions(
Expand Down
1 change: 1 addition & 0 deletions packages/rollup/src/executors/rollup/schema.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ export interface RollupExecutorOptions {
compiler?: 'babel' | 'tsc' | 'swc';
javascriptEnabled?: boolean;
generateExportsField?: boolean;
skipTypeCheck?: boolean;
}
5 changes: 5 additions & 0 deletions packages/rollup/src/executors/rollup/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@
"type": "boolean",
"description": "Generate package.json with 'exports' field. This field defines entry points in the package and is used by Node and the TypeScript compiler.",
"default": false
},
"skipTypeCheck": {
"type": "boolean",
"description": "Whether to skip TypeScript type checking.",
"default": false
}
},
"required": ["tsConfig", "main", "outputPath"],
Expand Down

0 comments on commit 4233eff

Please sign in to comment.