fix(js): postProcessInlinedDependencies throwing error on movePackage #16127
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/js/src/utils/inline.ts
Outdated
| @@ -88,6 +88,8 @@ export function postProcessInlinedDependencies( | |||
| } | |||
| } | |||
|
|
|||
| // TODO: hard-coded "libs" | |||
There was a problem hiding this comment.
Same as the /src above
There was a problem hiding this comment.
@nartc i could not find a function called libsDir, I found getWorkspaceLayout but there's no access to a Tree there. Could you point me to the right function? I'm gonna update the PR asap then.
Thank you!
There was a problem hiding this comment.
We should be handling this in a more generic way. FYI, the inline feature will be replaced in a future release but for now we should check if a package is already moved before attempting, rather than moving it here.
Temporary fix until nrwl/nx#16127 is merged and released
Temporary fix until nrwl/nx#16127 is merged and released
Temporary fix until nrwl/nx#16127 is merged and released
Temporary fix until nrwl/nx#16127 is merged and released
Moved the deletion of the `libs` folder to a later stage, to avoid errors when multiple libraries depend on the same library. fixes nrwl#16125
jaysoo
force-pushed
the
fix/js-postProcessInlinedDependencies-movePackage-error
branch
from
be48cd8 to
3f7157a
Compare
|
Amazing, thank you! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Moved the deletion of the
libsfolder to a later stage, to avoid errors when multiple libraries depend on the same library.closes #16125