@nrwl/js inline.ts postProcessInlinedDependencies tries to move the same inline library twice

[Itrulia]

Current Behavior

If you want to export non buildable libraries inside a publishable libraries, the postProcessInlinedDependencies tries to move the same library multiple times.

As the library has already moved the first time, the 2nd time will fail and throw an error.

This is caused by the following line:

nx/packages/js/src/utils/inline.ts

Line 82 in 6f747f9

movePackage(depOutputPath, destDepOutputPath);

Expected Behavior

Build does not error

GitHub Repo

https://github.com/Itrulia/nrwl-js-postProcessInlinedDependencies-issue

Steps to Reproduce

1. npm i
2. npx nx build website

Nx Report

nrwl-js-postProcessInlinedDependencies-issue on  main via  v16.16.0 on ☁️  [email protected]
❯ nx report
>  NX  Falling back to ts-node for local typescript execution. This may be a little slower.
  - To fix this, ensure @swc-node/register and @swc/core have been installed

 >  NX   Report complete - copy this into the issue template

   Node : 16.16.0
   OS   : darwin arm64
   npm  : 8.11.0

   nx                      : 15.9.2
   lerna                   : 3.22.1
   @nrwl/js                : 15.9.2
   @nrwl/jest              : 15.9.2
   @nrwl/linter            : 15.9.2
   @nrwl/workspace         : 15.9.2
   @nrwl/cli               : 15.9.2
   @nrwl/cypress           : 15.9.2
   @nrwl/devkit            : 15.9.2
   @nrwl/eslint-plugin-nx  : 15.9.2
   @nrwl/next              : 15.9.2
   @nrwl/node              : 15.9.2
   @nrwl/react             : 15.9.2
   @nrwl/storybook         : 15.9.2
   @nrwl/tao               : 15.9.2
   @nrwl/web               : 15.9.2
   @nrwl/webpack           : 15.9.2
   @nrwl/nx-cloud          : 15.3.3
   typescript              : 4.6.4

Failure Logs

Log of Object.values(inlineGraph.dependencies):

[
  [
    'page-website',
    'article-website',
    'navigation-website',
    'richtext-website',
    'membership-website',
    'block-content-website',
    'authentication-website',
    'website-builder',
    'website-api',
    'website-api-v2'
  ],
  [ 'website-api', 'website-builder', 'block-content-website' ],
  [
    'website-api', 'website-api',
    'website-api', 'website-api',
    'website-api', 'website-api',
    'website-api', 'website-api',
    'website-api', 'website-api',
    'website-api', 'website-api'
  ],
  [
    'website-builder',
    'website-api',
    'richtext-website',
    'website-builder',
    'website-api',
    'richtext-website',
    'website-builder',
    'website-api',
    'richtext-website'
  ],
  [
    'website-builder',
    'website-builder',
    'website-builder',
    'website-builder'
  ],
  [ 'website-api', 'website-builder', 'block-content-website' ],
  [ 'website-api', 'website-builder' ],
  [ 'website-builder', 'website-api', 'authentication-website' ],
  [ 'website-api', 'website-api' ]
]


Log of depOutputPath, destDepOutputPath:


/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/page/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/article/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/navigation/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/richtext/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/membership/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/block-content/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/authentication/website
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/website-builder
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/website-api
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/website-api-v2
/Users/itrulia/Documents/nrwl-js-postProcessInlinedDependencies-issue/dist/libs/website libs/website-api

Additional Information

This error is most likely happening because there are multiple libraries depending on the same library multiple times.

[Itrulia]

Still relevant so the bot doesn't mark it as stale

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.