-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): allow dependsOn to accept a single project dependency #16100
feat(core): allow dependsOn to accept a single project dependency #16100
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dc487dc
to
1af728f
Compare
1af728f
to
d4bba28
Compare
d4bba28
to
ee138a6
Compare
ee138a6
to
414b95e
Compare
414b95e
to
5698d49
Compare
packages/nx/src/migrations/update-16-0-0/update-depends-on-to-tokens.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/migrations/update-16-0-0/update-depends-on-to-tokens.ts
Outdated
Show resolved
Hide resolved
4fcb1d4
to
1b2416f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have separate tabs for the old and new syntax
212977b
to
6cc8098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the feature is great, but I would restructure the docs a bit. If you want, you can merge and then I can update the docs section.
I think we should do it like this:
- Full dependsOn syntax structure with tabs for < 16 and 16+
- Examples of usage with tabs for < 16 and 16+
- Specifying individual projects should still be in a tab for 16+ even though there is no corresponding < 16 tab
Sure, that sounds good. Thanks Issac! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
In its object form,
dependsOn
has aprojects
property. This property takes a string, despite being plural, and only acceptsself
ordependencies
as its value.Expected Behavior
projects
can be an array of project names, but supports{self}
and{dependencies}
as tokensRelated Issue(s)
Fixes #16100