Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nx-plugin): reuse utilities from create-nx-workspace for create-nx-plugin #15743

Merged
merged 3 commits into from
Mar 31, 2023
Merged

feat(nx-plugin): reuse utilities from create-nx-workspace for create-nx-plugin #15743

merged 3 commits into from
Mar 31, 2023

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 17, 2023 •
edited
Loading

Current Behavior

create-nx-plugin creates a monorepo containing one plugin

Expected Behavior

create-nx-plugin creates a repository containing a plugin as the base project

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 8:57PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8bddc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 6c0bdcb to 559370b Compare March 18, 2023 05:47
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 559370b to b165e0d Compare March 18, 2023 19:42
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from b165e0d to 60cea8c Compare March 20, 2023 14:28
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 60cea8c to df23b5b Compare March 20, 2023 14:35
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from df23b5b to 8600a0b Compare March 20, 2023 14:53
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 8600a0b to dd0db75 Compare March 20, 2023 16:42
FrozenPandaz
FrozenPandaz requested changes Mar 20, 2023
View reviewed changes
packages/eslint-plugin-nx/src/rules/nx-plugin-checks.ts Outdated
@@ -144,16 +146,16 @@ function normalizeOptions(
return {
...base,
executorsJson: base.executorsJson
? `${sourceProject.data.root}/${base.executorsJson}`
? resolve(`${sourceProject.data.root}/${base.executorsJson}`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to do much?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would change the paths to be absolute. Was there a bug before this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll double check if this is still needed - there was an issue when generating an Nx plugin at the root level that the lint rule was comparing ./generators.json with generators.json

packages/nx-plugin/src/generators/preset/files/src/index.ts__template__ Outdated Show resolved Hide resolved
packages/nx-plugin/src/generators/preset/generator.spec.ts Outdated Show resolved Hide resolved
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from dd0db75 to b973cdf Compare March 20, 2023 17:21
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from b973cdf to 6f3d6ef Compare March 20, 2023 17:31
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 6f3d6ef to 1ccb53c Compare March 20, 2023 19:05
@AgentEnder AgentEnder mentioned this pull request Mar 20, 2023
Closed
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 1ccb53c to 5dfaf14 Compare March 20, 2023 21:42
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 5dfaf14 to c96b264 Compare March 20, 2023 21:58
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from c96b264 to 01ddbea Compare March 21, 2023 15:02
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 01ddbea to 7ecd408 Compare March 21, 2023 15:51
@AgentEnder AgentEnder requested a review from juristr as a code owner March 24, 2023 20:47
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 12999db to 653a536 Compare March 29, 2023 14:31
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 653a536 to 0f5c066 Compare March 29, 2023 16:41
meeroslav
meeroslav reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment regarding e2e test

@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 0f5c066 to 1132637 Compare March 31, 2023 18:36
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 1132637 to 57d9cd7 Compare March 31, 2023 19:30
FrozenPandaz
FrozenPandaz approved these changes Mar 31, 2023
View reviewed changes
packages/nx-plugin/generators.json Outdated Show resolved Hide resolved
packages/nx-plugin/src/generators/preset/schema.json Outdated Show resolved Hide resolved
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 57d9cd7 to 78eb03f Compare March 31, 2023 20:14
@AgentEnder AgentEnder force-pushed the feat/create-nx-plugin-standalone branch from 78eb03f to c8bddc3 Compare March 31, 2023 20:54
@AgentEnder AgentEnder merged commit 6e7234c into nrwl:master Mar 31, 2023
@AgentEnder AgentEnder deleted the feat/create-nx-plugin-standalone branch March 31, 2023 21:23
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meeroslav meeroslav meeroslav left review comments

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@mandarini mandarini mandarini approved these changes

@bcabanes bcabanes bcabanes approved these changes

@jaysoo jaysoo jaysoo approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner

@nartc nartc Awaiting requested review from nartc

@ndcunningham ndcunningham Awaiting requested review from ndcunningham

@isaacplmann isaacplmann Awaiting requested review from isaacplmann

@juristr juristr Awaiting requested review from juristr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AgentEnder @jaysoo @meeroslav @bcabanes @mandarini @FrozenPandaz @barbados-clemens