-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix missing top-level dependencies #14832
fix(core): fix missing top-level dependencies #14832
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @daiscog! This looks good. You have some conflicts, and circle seems to be having some issues on this PR. Can you rebase and push it back up? If Circle still fails we may have to cherry-pick it over to a different branch. |
Hi @AgentEnder Sorry for the delay. I've now rebased with resolved conflicts. I am seeing a lot of seemingly unrelated test failures when running I've also had to push with I believe I've followed all contribution instructions correctly. Not sure if I'm missing something. 🤷♂️ |
@AgentEnder All tests passing now. :) |
@AgentEnder anything else I can do to help get this over the line? |
Fix dependencies sometimes being omitted from the list of top-level dependencies when they are both top-level and transitive closed #14513
This reverts commit 369ee09.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Fix dependencies sometimes being omitted from the list of top-level dependencies when they are both top-level and transitive
closed #14513