Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nrwl/web:file-server should expose additional options for http-server #14808

Closed
1 task done
rpd10 opened this issue Feb 5, 2023 · 1 comment · Fixed by #16546
Closed
1 task done

@nrwl/web:file-server should expose additional options for http-server #14808

rpd10 opened this issue Feb 5, 2023 · 1 comment · Fixed by #16546
Labels
outdated scope: react Issues related to React support for Nx type: feature

Comments

@rpd10
Copy link
Contributor

rpd10 commented Feb 5, 2023

Description

Today, running @nrwl/web:file-server does not expose a few useful options of the underlying http-server:

  • cache time (-c)
  • gzip compression (-g)
  • brotli compression (-b)

Motivation

When doing live reloading, etc. these options probably don't make much sense. But there are some use cases where they could. One example, we want to build the app in CI, and then spin up a quick server to host a production-like application for testing. Exposing those options with reasonable defaults would be useful in that scenario.

Suggested Implementation

Alternate Implementations

@rpd10 rpd10 changed the title nrwl/web:file-server should expose additional options for http-server @nrwl/web:file-server should expose additional options for http-server Feb 5, 2023
rpd10 added a commit to rpd10/nx that referenced this issue Feb 6, 2023
@AgentEnder AgentEnder added the scope: react Issues related to React support for Nx label Feb 7, 2023
jaysoo pushed a commit to jaysoo/nx that referenced this issue Apr 25, 2023
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react Issues related to React support for Nx type: feature
Projects
None yet
2 participants