fix(react): add migration to install @nrwl/webpack if needed by Story… #14480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Great one @jaysoo - any idea if we should also patch the generators to add |
mandarini
approved these changes
Jan 19, 2023
| let shouldInstall = false; | ||
|
|
||
| for (const [, config] of projects) { | ||
| let sbConfigPath = joinPathFragments(config.root, '.storybook/main.ts'); |
There was a problem hiding this comment.
Ideally, instead of joinPathFragments(config.root, '.storybook/main.ts') it should look for the storybook target (by searching for the @nrwl/storybook:storybook executor) and get the configDir, but I guess it's overengineering in this case. So I think it looks good.
jaysoo
force-pushed
the
issue/14455
branch
5 times, most recently
from
6c0ffb0 to
b1e6420
Compare
jaysoo
force-pushed
the
issue/14455
branch
4 times, most recently
from
5a5c0e6 to
9b17a04
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…book
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #14455