-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix dependent projects for watch #14170
fix(core): fix dependent projects for watch #14170
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d8f787a
to
86283db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we can avoid some extra iterations pretty easily if we use a set from the get go.
@@ -58,7 +58,7 @@ export function notifyFileWatcherSockets( | |||
const watchedProjects = [...config.watchProjects]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const watchedProjects = [...config.watchProjects]; | |
const watchedProjects = new Set() |
for (const project of config.watchProjects) { | ||
watchedProjects.push( | ||
...findAllProjectNodeDependencies( | ||
project, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (const project of config.watchProjects) { | |
watchedProjects.push( | |
...findAllProjectNodeDependencies( | |
project, | |
for (const project of config.watchProjects) { | |
watchedProjects.add(project) | |
for (const dep of findAllProjectNodeDependencies(...)) { | |
watchedProjects.add(dep) | |
} | |
} |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #