Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially redundant dependencies in Next.js template #11882

Closed
1 task
mcmxcdev opened this issue Sep 6, 2022 · 1 comment · Fixed by #16786
Closed
1 task

Potentially redundant dependencies in Next.js template #11882

mcmxcdev opened this issue Sep 6, 2022 · 1 comment · Fixed by #16786
Assignees
@ndcunningham
Labels
outdated scope: nextjs Issues related to NextJS support for Nx type: feature

Comments

@mcmxcdev
Copy link

mcmxcdev commented Sep 6, 2022

Description

When generating a simple Next.js project with npx create-nx-workspace --preset=next, I see at least three dependencies where I don't know why they come installed out of the box:

"core-js": "^3.6.5",
"regenerator-runtime": "0.13.7",
"react-test-renderer": "18.0.0"

core-js and regenerator-runtime seem to be compatibility layers which shouldn't be necessary in a modern project.

jest tests also work without react-test-renderer.

All three of these dependencies are never references in a freshly installed project.

Motivation

Get rid of redundant dependencies
@AgentEnder AgentEnder added the scope: nextjs Issues related to NextJS support for Nx label Sep 11, 2022
@ndcunningham ndcunningham self-assigned this May 4, 2023
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 4, 2023
@ndcunningham
fix(nextjs): remove outdated packages
cfb0987 
Features from these packages should be available

closed nrwl#11882
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 4, 2023
@ndcunningham
fix(nextjs): remove outdated packages
9ba0e03 
The features should be available by default

closed nrwl#11882
@ndcunningham ndcunningham mentioned this issue May 4, 2023
Merged
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 5, 2023
@ndcunningham
fix(nextjs): remove outdated packages
7aeed36 
The features should be available by default

closed nrwl#11882
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 5, 2023
@ndcunningham
fix(nextjs): remove outdated packages
07a6f76 
The features should be available by default

closed nrwl#11882
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 5, 2023
@ndcunningham
fix(nextjs): remove outdated packages
877e446 
The features should be available by default

closed nrwl#11882
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 5, 2023
@ndcunningham
fix(nextjs): remove outdated packages
07d438d 
The features should be available by default

closed nrwl#11882
ndcunningham added a commit to ndcunningham/nx that referenced this issue May 5, 2023
@ndcunningham
fix(react): remove outdated packages
7a0dd78 
closes: nrwl#11882
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ndcunningham ndcunningham

Labels
outdated scope: nextjs Issues related to NextJS support for Nx type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(react): remove outdated packages ndcunningham/nx
3 participants
@ndcunningham @AgentEnder @mcmxcdev