Skip to content

Commit

Permalink
chore(expo): disable expo install e2e tests (#16073)
Browse files Browse the repository at this point in the history
  • Loading branch information
xiongemi authored Apr 3, 2023
1 parent 86c2567 commit fdbdd98
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
4 changes: 3 additions & 1 deletion e2e/expo/src/expo.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ describe('expo', () => {
expect(prebuildResult.combinedOutput).toContain('Config synced');
});

it('should install', async () => {
// TODO(emily): expo-cli always fetches the latest version of react native
// re-enable it when expo-cli is fixed
xit('should install', async () => {
// run install command
const installResults = await runCLIAsync(
`install ${appName} --no-interactive --check`
Expand Down
8 changes: 2 additions & 6 deletions packages/expo/src/executors/prebuild/prebuild.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,12 @@ export default async function* prebuildExecutor(
await prebuildAsync(context.root, projectRoot, options);

if (options.install) {
await installAsync(context.root, {
fix: true,
});
await installAsync(context.root, { fix: true });
if (options.platform === 'ios') {
await podInstall(join(context.root, projectRoot, 'ios'));
}
} else {
await installAsync(context.root, {
check: true,
});
await installAsync(context.root, {});
}

yield {
Expand Down

0 comments on commit fdbdd98

Please sign in to comment.