Skip to content

Commit

Permalink
chore(react): mark application generator as required (#17218)
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxKless authored May 25, 2023
1 parent 636b911 commit f8b4f91
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions docs/generated/packages/react/generators/application.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"type": "string",
"$default": { "$source": "argv", "index": 0 },
"x-prompt": "What name would you like to use for the application?",
"pattern": "^[a-zA-Z].*$",
"x-priority": "important"
"pattern": "^[a-zA-Z].*$"
},
"directory": {
"description": "The directory of the new application.",
Expand Down Expand Up @@ -185,7 +184,7 @@
"default": false
}
},
"required": [],
"required": ["name"],
"examplesFile": "## Examples\n\n{% tabs %}\n{% tab label=\"Simple Application\" %}\n\nCreate an application named `my-app`:\n\n```bash\nnx g @nx/react:application my-app\n```\n\n{% /tab %}\n\n{% tab label=\"Application using Vite as bundler\" %}\n\nCreate an application named `my-app`:\n\n```bash\nnx g @nx/react:app my-app --bundler=vite\n```\n\n{% /tab %}\n\n{% tab label=\"Specify directory and style extension\" %}\n\nCreate an application named `my-app` in the `my-dir` directory and use `scss` for styles:\n\n```bash\nnx g @nx/react:app my-app --directory=my-dir --style=scss\n```\n\n{% /tab %}\n\n{% tab label=\"Add tags\" %}\n\nAdd tags to the application (used for linting).\n\n```bash\nnx g @nx/react:app my-app --tags=scope:admin,type:ui\n```\n\n{% /tab %}\n{% /tabs %}\n",
"presets": []
},
Expand Down
5 changes: 2 additions & 3 deletions packages/react/src/generators/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"index": 0
},
"x-prompt": "What name would you like to use for the application?",
"pattern": "^[a-zA-Z].*$",
"x-priority": "important"
"pattern": "^[a-zA-Z].*$"
},
"directory": {
"description": "The directory of the new application.",
Expand Down Expand Up @@ -191,6 +190,6 @@
"default": false
}
},
"required": [],
"required": ["name"],
"examplesFile": "../../../docs/application-examples.md"
}

1 comment on commit f8b4f91

@vercel
Copy link

@vercel vercel bot commented on f8b4f91 May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-five.vercel.app
nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app
nx.dev

Please sign in to comment.