fix(linter): ensure tslint converter works with pnp (#18323)

nrwl · Jul 28, 2023 · f4b7ec2 · f4b7ec2 · vercel · Jul 28, 2023
1 parent eb39210
commit f4b7ec2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/packages/angular/src/generators/convert-tslint-to-eslint/convert-tslint-to-eslint.spec.ts b/packages/angular/src/generators/convert-tslint-to-eslint/convert-tslint-to-eslint.spec.ts
@@ -14,7 +14,17 @@ import { conversionGenerator } from './convert-tslint-to-eslint';
 /**
  * Don't run actual child_process implementation of installPackagesTask()
  */
-jest.mock('child_process');
+jest.mock('child_process', () => {
+  return {
+    ...jest.requireActual<any>('child_process'),
+    execSync: jest.fn((command: string) => {
+      if (command.includes('pnpm --version')) {
+        return '8.2.0';
+      }
+      return;
+    }),
+  };
+});
 
 const appProjectName = 'angular-app-1';
 const appProjectRoot = `apps/${appProjectName}`;

diff --git a/packages/cypress/src/generators/convert-tslint-to-eslint/convert-tslint-to-eslint.spec.ts b/packages/cypress/src/generators/convert-tslint-to-eslint/convert-tslint-to-eslint.spec.ts
@@ -13,7 +13,17 @@ import { conversionGenerator } from './convert-tslint-to-eslint';
 /**
  * Don't run actual child_process implementation of installPackagesTask()
  */
-jest.mock('child_process');
+jest.mock('child_process', () => {
+  return {
+    ...jest.requireActual<any>('child_process'),
+    execSync: jest.fn((command: string) => {
+      if (command.includes('pnpm --version')) {
+        return '8.2.0';
+      }
+      return;
+    }),
+  };
+});
 
 const projectName = 'e2e-app-1';
 const projectRoot = `apps/${projectName}`;

diff --git a/packages/linter/src/utils/convert-tslint-to-eslint/convert-to-eslint-config.ts b/packages/linter/src/utils/convert-tslint-to-eslint/convert-to-eslint-config.ts
@@ -103,8 +103,9 @@ export async function convertToESLintConfig(
      */
     writeJsonFile(pathToTslintJson, updatedTSLintJson);
   }
+  const pm = getPackageManagerCommand();
   const reportedConfiguration = await findReportedConfiguration(
-    'npx tslint --print-config',
+    `${pm.exec} tslint --print-config`,
     pathToTslintJson
   );
 
@@ -121,8 +122,7 @@ export async function convertToESLintConfig(
      * This error could occur if, for example, the user does not have a TSLint plugin installed correctly that they
      * reference in their config.
      */
-    const printConfigFailureMessageStart =
-      'Command failed: npx tslint --print-config "tslint.json"';
+    const printConfigFailureMessageStart = `Command failed: ${pm.exec} tslint --print-config "tslint.json"`;
     if (
       reportedConfiguration.message.startsWith(printConfigFailureMessageStart)
     ) {