fix(module-federation): ensure shared packages can be shared from host …

…#27162
nrwl · Aug 19, 2024 · f20624b · f20624b
1 parent b91d788
commit f20624b
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 10 deletions.
diff --git a/...s/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...s/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -127,9 +127,12 @@ export async function* moduleFederationDevServerExecutor(
   options.staticRemotesPort ??= remotes.staticRemotePort;
 
   // Set NX_MF_DEV_REMOTES for the Nx Runtime Library Control Plugin
-  process.env.NX_MF_DEV_REMOTES = JSON.stringify(
-    remotes.devRemotes.map((r) => (typeof r === 'string' ? r : r.remoteName))
-  );
+  process.env.NX_MF_DEV_REMOTES = JSON.stringify([
+    ...(remotes.devRemotes.map((r) =>
+      typeof r === 'string' ? r : r.remoteName
+    ) ?? []),
+    project.name,
+  ]);
 
   const staticRemotesConfig = parseStaticRemotesConfig(
     [...remotes.staticRemotes, ...remotes.dynamicRemotes],

diff --git a/...r/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.ts b/...r/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.ts
@@ -123,7 +123,10 @@ export async function* moduleFederationSsrDevServerExecutor(
   );
 
   // Set NX_MF_DEV_REMOTES for the Nx Runtime Library Control Plugin
-  process.env.NX_MF_DEV_REMOTES = JSON.stringify(options.devRemotes);
+  process.env.NX_MF_DEV_REMOTES = JSON.stringify([
+    ...(options.devRemotes ?? []),
+    project.name,
+  ]);
 
   const devRemotes = await startRemotes(
     remotes.devRemotes,

diff --git a/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -332,9 +332,12 @@ export default async function* moduleFederationDevServer(
   options.staticRemotesPort ??= remotes.staticRemotePort;
 
   // Set NX_MF_DEV_REMOTES for the Nx Runtime Library Control Plugin
-  process.env.NX_MF_DEV_REMOTES = JSON.stringify(
-    remotes.devRemotes.map((r) => (typeof r === 'string' ? r : r.remoteName))
-  );
+  process.env.NX_MF_DEV_REMOTES = JSON.stringify([
+    ...(remotes.devRemotes.map((r) =>
+      typeof r === 'string' ? r : r.remoteName
+    ) ?? []),
+    p.name,
+  ]);
 
   const staticRemotesConfig = parseStaticRemotesConfig(
     [...remotes.staticRemotes, ...remotes.dynamicRemotes],

diff --git a/...t/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.ts b/...t/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.ts
@@ -310,9 +310,12 @@ export default async function* moduleFederationSsrDevServer(
 
   options.staticRemotesPort ??= remotes.staticRemotePort;
 
-  process.env.NX_MF_DEV_REMOTES = JSON.stringify(
-    remotes.devRemotes.map((r) => (typeof r === 'string' ? r : r.remoteName))
-  );
+  process.env.NX_MF_DEV_REMOTES = JSON.stringify([
+    ...(remotes.devRemotes.map((r) =>
+      typeof r === 'string' ? r : r.remoteName
+    ) ?? []),
+    projectConfig.name,
+  ]);
 
   const staticRemotesConfig = parseStaticSsrRemotesConfig(
     [...remotes.staticRemotes, ...remotes.dynamicRemotes],