Skip to content

Commit

Permalink
feat(nx-dev): anchor links to version instead of timestamp
Browse files Browse the repository at this point in the history
  • Loading branch information
isaacplmann authored and juristr committed Jul 6, 2023
1 parent 0f9cece commit e60702f
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions nx-dev/nx-dev/pages/reference/changelog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export default function Changelog(props: ChangeLogProps): JSX.Element {
<div className="h-2 w-2 rounded-full bg-slate-100 ring-1 ring-slate-300 dark:ring-slate-500 dark:bg-slate-600" />
</div>
<div
id={convertToDate(changelog.date).toLocaleDateString()}
id={changelog.version}
className="flex flex-col w-36 shrink-0 group"
>
<p className="py-0.5">
Expand All @@ -269,6 +269,9 @@ export default function Changelog(props: ChangeLogProps): JSX.Element {
/>{' '}
v{changelog.version}
</a>
<a aria-hidden="true" href={`#${changelog.version}`}>
<LinkIcon className="ml-2 mb-1 inline h-5 w-5 opacity-0 group-hover:opacity-100" />
</a>
</p>
<p className="py-0.5 text-xs leading-5 text-slate-400 dark:text-slate-500">
<time
Expand All @@ -277,14 +280,6 @@ export default function Changelog(props: ChangeLogProps): JSX.Element {
).toLocaleDateString()}
>
{changelog.date}
<a
aria-hidden="true"
href={`#${convertToDate(
changelog.date
).toLocaleDateString()}`}
>
<LinkIcon className="ml-2 mb-1 inline h-5 w-5 opacity-0 group-hover:opacity-100" />
</a>
</time>
</p>
</div>
Expand Down

1 comment on commit e60702f

@vercel
Copy link

@vercel vercel bot commented on e60702f Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-git-master-nrwl.vercel.app
nx-five.vercel.app
nx-dev-nrwl.vercel.app
nx.dev

Please sign in to comment.