fix(misc): safely iterate over package.json scripts in nx init command (

#16508)
nrwl · Apr 24, 2023 · dffb3d3 · dffb3d3 · vercel · Apr 24, 2023
1 parent 26ad8eb
commit dffb3d3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/nx/src/nx-init/add-nx-to-nest.ts b/packages/nx/src/nx-init/add-nx-to-nest.ts
@@ -51,7 +51,7 @@ export async function addNxToNest(options: Options, packageJson: PackageJson) {
     'test:watch',
   ];
 
-  const scripts = Object.keys(packageJson.scripts).filter((s) => {
+  const scripts = Object.keys(packageJson.scripts ?? {}).filter((s) => {
     if (nestCacheableScripts.includes(s) || nestIgnoreScripts.includes(s)) {
       return false;
     }

diff --git a/packages/nx/src/nx-init/add-nx-to-npm-repo.ts b/packages/nx/src/nx-init/add-nx-to-npm-repo.ts
@@ -25,7 +25,7 @@ export async function addNxToNpmRepo(options: Options) {
   let useNxCloud: boolean;
 
   const packageJson = readJsonFile('package.json');
-  const scripts = Object.keys(packageJson.scripts).filter(
+  const scripts = Object.keys(packageJson.scripts ?? {}).filter(
     (s) => !s.startsWith('pre') && !s.startsWith('post')
   );
 

diff --git a/packages/nx/src/nx-init/angular/standalone-workspace.ts b/packages/nx/src/nx-init/angular/standalone-workspace.ts
@@ -43,7 +43,7 @@ export async function setupStandaloneWorkspace(
   // convert workspace config format to standalone project configs
   // update its targets outputs and delete angular.json
   const projects = toNewFormat(angularJson).projects;
-  for (const [projectName, project] of Object.entries(projects)) {
+  for (const [projectName, project] of Object.entries(projects ?? {})) {
     updateProjectOutputs(repoRoot, project);
     writeJsonFile(join(project.root, 'project.json'), {
       $schema: normalizePath(
@@ -162,7 +162,7 @@ function getWorkspaceCapabilities(
     karmaProjectConfigFile: false,
   };
 
-  for (const project of Object.values(projects)) {
+  for (const project of Object.values(projects ?? {})) {
     if (
       !capabilities.eslintProjectConfigFile &&
       projectHasEslintConfig(project)