Skip to content

Commit

Permalink
fix(remix): pin testing-library/jest-dom to compatible version (#23161)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
@testing-library/jest-dom released a version that is broken currently
and it was being found by our version string.



## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Pin the version of the package to the latest working versions


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
Coly010 authored May 3, 2024
1 parent dbad02a commit dc54b55
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/remix/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ export const eslintVersion = '^8.56.0';
export const typescriptVersion = '^5.3.3';
export const tailwindVersion = '^3.3.0';
export const testingLibraryReactVersion = '^14.1.2';
export const testingLibraryJestDomVersion = '^6.2.0';
// TODO(colum): Unpin this when @testing-library/jest-dom pushes a fix
export const testingLibraryJestDomVersion = '6.4.2';
export const testingLibraryUserEventsVersion = '^14.5.2';

export function getRemixVersion(tree: Tree): string {
Expand Down

0 comments on commit dc54b55

Please sign in to comment.